Omniscia Olympus DAO Audit
Ownable Code Style Findings
Ownable Code Style Findings
OWN-01C: Inexistent Deletion of Pending Owner
Type | Severity | Location |
---|---|---|
Gas Optimization | Informational | Ownable.sol:L39-L43 |
Description:
The _newOwner
entry should be deleted when it is consumed by the pullManagement
function.
Example:
contracts/types/Ownable.sol
39function pullManagement() public virtual override {40 require( msg.sender == _newOwner, "Ownable: must be new owner to pull");41 emit OwnershipPulled( _owner, _newOwner );42 _owner = _newOwner;43}
Recommendation:
We advise it to be deleted so to ensure a consistent contract state.
Alleviation:
The new owner is now properly deleted when the pullManagement
function concludes.