Omniscia Olympus DAO Audit
sOlympusERC20 Static Analysis Findings
sOlympusERC20 Static Analysis Findings
OEC-01S: Illegible Numeric Literal
| Type | Severity | Location |
|---|---|---|
| Code Style | Informational | sOlympusERC20.sol:L55 |
Description:
The linked variable contains a numeric literal with too many digits and no separator.
Example:
contracts/sOlympusERC20.sol
55uint256 private constant INITIAL_FRAGMENTS_SUPPLY = 5000000 * 10**9;Recommendation:
We advise the special numeric separator (_) to be used to discern per thousand units (i.e. 10000 becomes 10_000), increasing the legibility of the codebase.
Alleviation:
The underscore (_) numeric separator was properly introduced to the linked variable.
OEC-02S: Improper Inheritence
| Type | Severity | Location |
|---|---|---|
| Code Style | Informational | sOlympusERC20.sol:L12 |
Description:
The sOlympus contract complies with the IsOHM interface of the codebase yet does not inherit it.
Example:
contracts/sOlympusERC20.sol
12contract sOlympus is ERC20Permit {Recommendation:
We advise the contract to properly inherit it ensuring consistency and maintainability across the codebase.
Alleviation:
The now properly inherits the IsOHM interface.