Omniscia Astrolab DAO Audit
Code Style
Code Style
During the manual portion of the audit, we identified 53 optimizations that can be applied to the codebase that will decrease the operational cost associated with the execution of a particular function and generally ensure that the project complies with the latest best practices and standards in Solidity.
Additionally, this section of the audit contains any opinionated adjustments we believe the code should make to make it more legible as well as truer to its purpose.
These optimizations are enumerated below:
| ID | Severity | Addressed | Title |
|---|---|---|---|
| A62-01C |  |  | Inefficient mapping Lookups |
| A62-02C | |  | Redundant Duplication of Code |
| A62-03C | | | Redundant Parenthesis Statements |
| A62-04C | | | Repetitive Value Literal |
| AAT-01C | | | Generic Typographic Mistakes |
| AAT-02C | | | Improper Declaration of Abstract Function |
| AAC-01C | | | Inefficient Usage of Utility Functions |
| AAC-02C | | | Redundant Input Argument |
| AAC-03C | | | Redundant Local Variable |
| AAG-01C | | | Repetitive Value Literal |
| AAS-01C | | | Ineffectual Usage of Safe Arithmetics |
| AAS-02C | | | Inefficient Iteration of Search Loops |
| AAS-03C | | | Inefficient Iterator Type |
| AAS-04C | | | Inexistent Error Messages |
| AAS-05C | | | Loop Iterator Optimizations |
| AME-01C | | | Generic Typographic Mistakes |
| AME-02C | |  | Inexistent Error Message |
| AME-03C | | | Redundant Parenthesis Statements |
| AMS-01C | | | Generic Typographic Mistakes |
| AMS-02C | | | Ineffectual Usage of Safe Arithmetics |
| AMS-03C | | | Inexistent Error Messages |
| AMS-04C | | | Redundant Parenthesis Statements |
| APY-01C | | | Inefficient Generation of Selector |
| ARE-01C | | | Improper Declarations of Abstract Functions |
| ARE-02C | | | Inefficient Erasure of Request |
| ARE-03C | | | Inefficient mapping Lookups |
| ARE-04C | | | Inexistent Error Messages |
| ARA-01C | | | Optimization of Data Structure |
| ASS-01C | | | Ineffectual Usage of Safe Arithmetics |
| ASS-02C | | | Inefficient Loop Limit Evaluations |
| ASS-03C | | | Inexistent Error Message |
| ASS-04C | | | Loop Iterator Optimization |
| ASS-05C | | | Redundant Deletion Operation |
| CUS-01C | | | Ineffectual Usage of Safe Arithmetics |
| CUS-02C | | | Repetitive Value Literal |
| PUS-01C | | | Ineffectual Usage of Safe Arithmetics |
| PUS-02C | | | Repetitive Value Literal |
| SV5-01C | | | Generic Typographic Mistake |
| SV5-02C | | | Improper Declarations of Abstract Functions |
| SV5-03C | | | Ineffectual Usage of Safe Arithmetics |
| SV5-04C | | | Inefficient Iterator Type |
| SV5-05C | | | Loop Iterator Optimizations |
| SV5-06C | | | Redundant Application of Access Control |
| SV5-07C | | | Redundant Parenthesis Statement |
| SVT-01C | | | Generic Typographic Mistakes |
| SVA-01C | | | Inefficient Iterator Type |
| SVA-02C | | | Loop Iterator Optimizations |
| SVC-01C | | | Generic Typographic Mistake |
| SVC-02C | | | Loop Iterator Optimization |
| SVC-03C | | | Repetitive Value Literal |
| SVP-01C | | | Generic Typographic Mistake |
| SVP-02C | | | Loop Iterator Optimizations |
| SVP-03C | | | Repetitive Value Literal |