Omniscia Astrolab DAO Audit
AsAccounting Code Style Findings
AsAccounting Code Style Findings
AAG-01C: Repetitive Value Literal
| Type | Severity | Location |
|---|---|---|
| Code Style |  | AsAccounting.sol:L126, L127, L128 |
Description:
The linked value literal is repeated across the codebase multiple times.
Example:
src/libs/AsAccounting.sol
126_fees.entry <= 200 && // 2%Recommendation:
We advise it to be set to a constant variable instead optimizing the legibility of the codebase.
Alleviation (59b75fbee1d8f3dee807c928f18be41c58b904e1):
Proper constant declarations have been introduced for all relevant maximum fee limitations inclusive of the ones referenced by this exhibit, thereby addressing it in full.