Omniscia Astrolab DAO Audit

As4626Abstract Static Analysis Findings

As4626Abstract Static Analysis Findings

AAT-01S: Inexistent Event Emission

Description:

The linked function adjusts a sensitive contract variable yet does not emit an event for it.

Example:

src/abstract/As4626Abstract.sol
98function setExemption(address _account, bool _isExempt) public onlyAdmin {
99 exemptionList[_account] = _isExempt;
100}

Recommendation:

We advise an event to be declared and correspondingly emitted to ensure off-chain processes can properly react to this system adjustment.

Alleviation (59b75fbee1d8f3dee807c928f18be41c58b904e1):

The Astrolab DAO team evaluated this exhibit and specified that they have consciously removed certain event emissions due to their impact on the bytecode size of the contracts.

In light of this issue, critical events have been selectively re-introduced where possible in compliance with the bytecode size limitations of the blockchain the contracts are deployed in.

As such, we consider this exhibit addressed to the greatest extent possible when acknowledging EVM related constraints.