AsManageable Code Style Findings

AME-01C: Generic Typographic Mistakes

Type	Severity	Location
Code Style		AsManageable.sol:L30, L31

Description:

The referenced lines contain typographical mistakes (i.e. private variable without an underscore prefix) or generic documentational errors (i.e. copy-paste) that should be corrected.

Example:

Copy
30uint256 private constant TIMELOCK_PERIOD = 2 days;

Recommendation:

We advise them to be corrected enhancing the legibility of the codebase.

Alleviation (59b75fbee1d8f3dee807c928f18be41c58b904e1):

The referenced variables have been renamed and their visibility specifier has been adjusted to public, effectively addressing this exhibit as the names are now correctly not prefixed with an underscore.

AME-02C: Inexistent Error Message

Type	Severity	Location
Code Style		AsManageable.sol:L84

Description:

The linked require check has no error message explicitly defined.

Example:

Copy
84require(!hasRole(role, account));

Recommendation:

We advise one to be set so to increase the legibility of the codebase and aid in validating the require check's condition.

Alleviation (59b75fbee1d8f3dee807c928f18be41c58b904e1):

The require check remains without an explicit error message or in-line documentation justifying it in its relocated AccessController::grantRole location, rendering the exhibit acknowledged.

AME-03C: Redundant Parenthesis Statements

Type	Severity	Location
Code Style		AsManageable.sol:L140, L173, L175

Description:

The referenced statements are redundantly wrapped in parenthesis' (()).

Example:

Copy
140if ((role == DEFAULT_ADMIN_ROLE) && account == msg.sender)

Recommendation:

We advise them to be safely omitted, increasing the legibility of the codebase.

Alleviation (59b75fbee1d8f3dee807c928f18be41c58b904e1):

The first of the three referenced redundant parenthesis statements is no longer present in the codebase whilst the latter two could be justified as a legibility increase, rendering this exhibit ultimately alleviated.