StrategyV5 Static Analysis Findings

SV5-01S: Inexistent Event Emission

Type	Severity	Location
Language Specific		StrategyV5.sol:L98-L101

Description:

The linked function adjusts a sensitive contract variable yet does not emit an event for it.

Example:

Copy
98function updateAgent(address _agent) external onlyAdmin {
99    if (_agent == address(0)) revert AddressZero();
100    agent = _agent;
101}

Recommendation:

We advise an event to be declared and correspondingly emitted to ensure off-chain processes can properly react to this system adjustment.

Alleviation (59b75fbee1d8f3dee807c928f18be41c58b904e1):

The Astrolab DAO team evaluated this exhibit and specified that they have consciously removed certain event emissions due to their impact on the bytecode size of the contracts.

In light of this issue, critical events have been selectively re-introduced where possible in compliance with the bytecode size limitations of the blockchain the contracts are deployed in.

As such, we consider this exhibit addressed to the greatest extent possible when acknowledging EVM related constraints.