Omniscia Astrolab DAO Audit
As4626Abstract Manual Review Findings
As4626Abstract Manual Review Findings
AAT-01M: EIP-7540 Incompatibility
Type | Severity | Location |
---|---|---|
Standard Conformity | ![]() | As4626Abstract.sol:L40-L45 |
Description:
The RedeemRequest
event declaration within the As4626Abstract
contract does not comply with the specification of the EIP.
Impact:
A severity of minor has been assigned as the incompatibility will solely affect off-chain consumers of these events, however, it is imperative that the incompatibility is rectified.
Example:
src/abstract/As4626Abstract.sol
39// ERC754040event RedeemRequest(41 address indexed sender,42 address indexed operator,43 address indexed owner,44 uint256 assets45);
Recommendation:
We advise the event arguments as well as names to be updated to comply with the EIP-7540 standard as otherwise compatibility with it should not be advertised.
Alleviation (59b75fbee1d8f3dee807c928f18be41c58b904e1):
The event has been updated to become fully compliant with the latest EIP-7540 standard definition as of 04-15-2024, alleviating this exhibit.