Omniscia Astrolab DAO Audit
As4626 Static Analysis Findings
As4626 Static Analysis Findings
A62-01S: Inexistent Event Emissions
| Type | Severity | Location |
|---|---|---|
| Language Specific |  | As4626.sol:L353-L356, L362-L364, L370-L372, L378-L380, L411-L414, L421-L423, L430, L432, L439-L443 |
Description:
The linked functions adjust sensitive contract variables yet do not emit an event for it.
Example:
src/abstract/As4626.sol
362function setMaxSlippageBps(uint16 _slippageBps) external onlyManager {363 maxSlippageBps = _slippageBps;364}Recommendation:
We advise an event to be declared and correspondingly emitted for each function to ensure off-chain processes can properly react to this system adjustment.
Alleviation (59b75fbee1d8f3dee807c928f18be41c58b904e1):
The Astrolab DAO team evaluated this exhibit and specified that they have consciously removed certain event emissions due to their impact on the bytecode size of the contracts.
In light of this issue, critical events have been selectively re-introduced where possible in compliance with the bytecode size limitations of the blockchain the contracts are deployed in.
As such, we consider this exhibit addressed to the greatest extent possible when acknowledging EVM related constraints.