Omniscia Astrolab DAO Audit

AsRescuableAbstract Code Style Findings

AsRescuableAbstract Code Style Findings

ARA-01C: Optimization of Data Structure

Description:

The RescueRequest data structure will occupy two storage slots redundantly as the timestamp value will fit reasonably within 96 bits as a Unix timestamp.

Example:

src/abstract/AsRescuableAbstract.sol
14struct RescueRequest {
15 uint256 timestamp;
16 address receiver;
17}
18mapping(address => RescueRequest) internal rescueRequests;

Recommendation:

We advise the data type of the timestamp to be updated, ensuring that each rescueRequests entry occupies a single storage slot.

Alleviation (59b75fbee1d8f3dee807c928f18be41c58b904e1):

The RescueRequest data structure, now relocated to the AsRescuable implementation, has not applied the timestamp related optimization rendering this exhibit acknowledged.