Omniscia Kyo Finance Audit
Code Style
Code Style
During the manual portion of the audit, we identified 26 optimizations that can be applied to the codebase that will decrease the operational cost associated with the execution of a particular function and generally ensure that the project complies with the latest best practices and standards in Solidity.
Additionally, this section of the audit contains any opinionated adjustments we believe the code should make to make it more legible as well as truer to its purpose.
These optimizations are enumerated below:
| ID | Severity | Addressed | Title |
|---|---|---|---|
| NEN-01C |  |  | Redundant Explicitly Named Argument |
| NPM-01C | | | Inefficient Initialization of Position |
| SSC-01C | | | Inexistent Conditional Chaining |
| STS-01C | | | Ineffectual Usage of Safe Arithmetics |
| STS-02C | | | Repetitive Value Literals |
| SMH-01C | | | Redundant Interim Pointer |
| SMH-02C | | | Redundant Parenthesis Statement |
| SMH-03C | |  | Redundant Relay of Rewards Owed |
| TSC-01C | | | Illegible Value Literal Representation |
| TSE-01C | | | Illegible Value Literal Representation |
| TSE-02C | | | Redundant Interim Variable |
| TSS-01C | | | External Requirements of Sensitive Functions |
| TSS-02C | | | Inexplicable Variable Type |
| TSS-03C | | | Redundant Usage of Immutable Variable |
| UVG-01C | | | Ineffectual Usage of Safe Arithmetics |
| UVG-02C | | | Inexistent Revert Statement |
| UVF-01C | | | Inexistent Error Messages |
| UVF-02C | | | Repetitive Value Literal |
| UVP-01C | | | Ineffectual Usage of Safe Arithmetics |
| UVP-02C | | | Inefficient Conditional Trigger |
| UVP-03C | | | Inefficient Evaluations of Both Input Tokens |
| UVP-04C | | | Inefficient Structure Pointer Type |
| UVP-05C | | | Redundant Casting Sequence |
| UVP-06C | | | Repetitive Value Literal |
| UVP-07C | | | Unconditional Increment of Fee Growth Global |
| VRE-01C | | | Redundant Contract Import |