Omniscia Kyo Finance Audit
UniswapV3Factory Code Style Findings
UniswapV3Factory Code Style Findings
UVF-01C: Inexistent Error Messages
| Type | Severity | Location |
|---|---|---|
| Code Style | ![]() | UniswapV3Factory.sol:L46, L48, L50, L51, L76, L80, L81, L99, L105 |
Description:
The linked require checks have no error messages explicitly defined.
Example:
contracts/univ3/UniswapV3Factory.sol
46require(tokenA != tokenB);Recommendation:
We advise each to be set so to increase the legibility of the codebase and aid in validating the require checks' conditions.
Alleviation (17c8d4e59f398021156f6f9657ff278aae0462ae):
The Kyo Finance team evaluated this exhibit but opted to acknowledge it in the current iteration of the codebase.
UVF-02C: Repetitive Value Literal
| Type | Severity | Location |
|---|---|---|
| Code Style | ![]() | UniswapV3Factory.sol:L76, L99, L105 |
Description:
The linked value literal is repeated across the codebase multiple times.
Example:
contracts/univ3/UniswapV3Factory.sol
76require(fee <= 1e6);Recommendation:
We advise it to be set to a constant variable instead, optimizing the legibility of the codebase.
In case the constant has already been declared, we advise it to be properly re-used across the code.
Alleviation (17c8d4e59f398021156f6f9657ff278aae0462ae):
The Kyo Finance team evaluated this exhibit but opted to acknowledge it in the current iteration of the codebase.
