Omniscia Kyo Finance Audit

TokenStreamConsumer Code Style Findings

TokenStreamConsumer Code Style Findings

TSC-01C: Illegible Value Literal Representation

Description:

The referenced pendingInputAmountCacheSlot value is set to a value literal meant to correlate to the EIP-7201 representation of the "TokenStreamConsumer.pendingInputAmountCached" string whose validation is hindered due to the usage of the said literal.

Example:

contracts/reward/TokenStreamConsumer.sol
12bytes32 private constant pendingInputAmountCacheSlot = 0x9bff43e48456609f6db56d12441696de4ee3adb372cd3bab07a15d4d26c65400; // erc7201 "TokenStreamConsumer.pendingInputAmountCached"

Recommendation:

We advise the assignment to be updated to the EIP-7201 expression as the variable can remain constant if it utilizes calculations known at compile time.

Alleviation (17c8d4e59f398021156f6f9657ff278aae0462ae):

The Kyo Finance team evaluated this exhibit but opted to acknowledge it in the current iteration of the codebase.