Omniscia Kyo Finance Audit

UniswapV3PoolDeployer Static Analysis Findings

UniswapV3PoolDeployer Static Analysis Findings

UVD-01S: Inexistent Sanitization of Input Addresses

Description:

The linked function(s) accept address arguments yet do not properly sanitize them.

Impact:

The presence of zero-value addresses, especially in constructor implementations, can cause the contract to be permanently inoperable. These checks are advised as zero-value inputs are a common side-effect of off-chain software related bugs.

Example:

contracts/univ3/UniswapV3PoolDeployer.sol
17constructor(address creationCode_, address electorCreationCode_) {
18 creationCode = creationCode_;
19 electorCreationCode = electorCreationCode_;
20}

Recommendation:

We advise some basic sanitization to be put in place by ensuring that each address specified is non-zero.

Alleviation (17c8d4e59f398021156f6f9657ff278aae0462ae):

The Kyo Finance team evaluated this exhibit but opted to acknowledge it in the current iteration of the codebase.