Omniscia Kyo Finance Audit
Manual Review
Manual Review
A thorough line-by-line review was conducted on the codebase to identify potential malfunctions and vulnerabilities in Kyo Finance's reward, voting and AMM infrastructure.
As the project at hand implements multiple AMM-interacting DeFi contracts, intricate care was put into ensuring that the flow of funds within the system conforms to the specifications and restrictions laid forth within the protocol's specification.
We validated that all state transitions of the system occur within sane criteria and that all rudimentary formulas within the system execute as expected. We pinpointed multiple significant vulnerabilities within the system which could have had severe ramifications to its overall operation; for more information, kindly consult the audit report's summary as well as dedicated major-severity exhibits.
Additionally, the system was investigated for any other commonly present attack vectors such as re-entrancy attacks, mathematical truncations, logical flaws and ERC / EIP standard inconsistencies. The documentation of the project was satisfactory to a certain extent, however, we strongly recommend it to be expanded at certain complex points such as the per-second formulae of the SmoothTokenStreamConsumer implementation.
A total of 39 findings were identified over the course of the manual review of which 13 findings concerned the behaviour and security of the system. The non-security related findings, such as optimizations, are included in the separate Code Style chapter.
The finding table below enumerates all these security / behavioural findings:
| ID | Severity | Addressed | Title |
|---|---|---|---|
| ERC-01M |  |  | Deviation of EIP-4626 Deposit / Withdrawal Restriction |
| ENO-01M |  |  | Inexistent Specification of EIP-20 Token Metadata |
| ENO-02M | | | Inexistent Validation of Input Token |
| LTN-01M | | | Deviation of EIP-4626 Withdrawal Restriction |
| STS-01M |  | | Discrepancy of Mathematical Formulae |
| STS-02M |  | | Improper Evaluation of Last Update Time |
| SMH-01M | | | Non-Standard Overflow-Prone Reward Accounting |
| SMH-02M | | | Incorrect Claimable Calculation |
| TSC-01M | | | Insecure Caching System |
| TSE-01M | | | Insecure Caching System |
| TSS-01M | | | Inefficient & Incorrect Distribution Count Evaluation |
| UVB-01M | | | Inexistent Naming Distinction of Uniswap Version |
| UVG-01M | | | Inexplicable Multiplication of Constant Product Liquidity Calculation |