Omniscia Nexera Audit

DoRecoverErc1155FractionsFacet Code Style Findings

DoRecoverErc1155FractionsFacet Code Style Findings

DRE-01C: Redundant Function Implementations

TypeSeverityLocation
Gas OptimizationDoRecoverErc1155FractionsFacet.sol:
I-1: L13
I-2: L14

Description:

The referenced function implementations are redundant as they would result in a no-op.

Example:

packages/contracts/contracts/subInternalFacets/recoverFractionsPhaseFacets/doRecoverFractionsFacets/doRecoverErc1155FractionsFacet/DoRecoverErc1155FractionsFacet.sol
13function initDoRecoverFractionsFacet(bytes calldata initDoRecoverFractionsData) external {}
14function setAndCheckDoRecoverFractions(bytes calldata postFractionDoRecoverFractionsData) external {}

Recommendation:

We advise them to be omitted or their explicit variable names to be removed, either of which we consider acceptable.

Alleviation (d682057ecb0e254069773d64f32c068cedb71e2a):

As the function modifiers are now applied, we consider this exhibit no longer applicable.