Omniscia Nexera Audit

PropWrappedAssetsFeeCollectorFacetStorage Code Style Findings

PropWrappedAssetsFeeCollectorFacetStorage Code Style Findings

PWF-01C: Inexistent Documentation of Storage Slot

Description:

The referenced STORAGE_SLOT does not have its actual result specified in its in-line documentation as it remains a TO-DO.

Example:

packages/contracts/contracts/privateFacets/preFractionsFacets/PropWrappedAssetsFeeCollectorFacetStorage.sol
42/**
43 * @dev Unique identifier for the storage slot where the Layout struct is stored. Derived from the ERC7201 formula.
44 * STORAGE_SLOT: TO-DO
45 */
46bytes32 internal constant STORAGE_SLOT =
47 keccak256(abi.encode(uint256(keccak256("Evergonlabs.Tmi-Tokenizer.storage.PropWrappedAssetsFeeCollectorFacetStorage")) - 1)) &
48 ~bytes32(uint256(0xff));

Recommendation:

We advise the 0xce30ba4b4ddb27e47562d0e2b85e521bcc246cd8a475b361b9a1b4a8edb63c00 storage slot to be properly specified in its comments, aiding in debugging of the contract's structure.

Alleviation (d682057ecb0e254069773d64f32c068cedb71e2a):

The correct storage slot has been specified as advised.