Omniscia Nexera Audit

PurchaseSkeletonGenesisIdsStorage Code Style Findings

PurchaseSkeletonGenesisIdsStorage Code Style Findings

PSS-01C: Inexistent Documentation of Storage Slot

Description:

The referenced STORAGE_SLOT does not have its actual result specified in its in-line documentation as it remains a TO_DO.

Example:

packages/contracts/contracts/purchaseStorage/PurchaseSkeletonGenesisIdsStorage.sol
8/** ================================================== STORAGE =================================================
9 * @dev Unique identifier for the storage slot where the Layout struct is stored. Derived from the ERC7201 formula.
10 * STORAGE_SLOT: TO-DO
11 */
12bytes32 internal constant STORAGE_SLOT =
13 keccak256(abi.encode(uint256(keccak256("Evergonlabs.Tmi-Tokenizer.storage.PurchaseSkeletonGenesisIdsStorage")) - 1)) &
14 ~bytes32(uint256(0xff));

Recommendation:

We advise the 0xb21b293f7a3d8c354e186cbd4cc8a545bd35e08fadc61e0da54d3930dcb70b00 storage slot to be properly specified in its comments, aiding in debugging of the contract's structure.

Alleviation (d682057ecb0e254069773d64f32c068cedb71e2a):

The correct storage slot has been specified as advised.