DoTransferPacketsFacet Code Style Findings

DTP-01C: Redundant Function Implementations

Type	Severity	Location
Gas Optimization		DoTransferPacketsFacet.sol: • I-1: L14 • I-2: L17

Description:

The referenced functions are either no-ops or are never invoked within the codebase.

Example:

Copy
13/// @inheritdoc IDoPurchaseFacet
14function initDoPurchaseFacet(bytes calldata initDoPurchaseData) external onlyExternalDelegateCall {}
15
16/// @inheritdoc IDoPurchaseFacet
17function setAndCheckDoPurchase(bytes calldata postFractionDoPurchaseData) external onlyInternalDelegateCall {}

Recommendation:

We advise them to be omitted, optimizing the code's structure.

Alternatively, we advise their explicit variable names to be removed so as to optimize their low-level bytecode representation.

Alleviation (d682057ecb0e254069773d64f32c068cedb71e2a):

The referenced function(s) apply modifier implementations considered crucial in derivative implementations, rendering this recommendation inapplicable.