Erc1155WithGenesisFractionFacetStorage Code Style Findings

EWF-01C: Inexistent Documentation of Storage Slot

Type	Severity	Location
Code Style		Erc1155WithGenesisFractionFacetStorage.sol:L31

Description:

The referenced STORAGE_SLOT does not have its actual result specified in its in-line documentation as it remains a TO-DO.

Example:

Copy
29/** ================================================== STORAGE =================================================
30 * @dev Unique identifier for the storage slot where the Layout struct is stored. Derived from the ERC7201 formula.
31 * STORAGE_SLOT: TO-DO
32 */
33bytes32 internal constant STORAGE_SLOT =
34    keccak256(abi.encode(uint256(keccak256("Evergonlabs.Tmi-Tokenizer.storage.Erc1155WithGenesisFractionFacetStorage")) - 1)) &
35        ~bytes32(uint256(0xff));

Recommendation:

We advise the 0x6b9b5f8a3cb7835a12587e921825f1fbd88eefc9a53083f2d9316d71d2373000 storage slot to be properly specified in its comments, aiding in debugging of the contract's structure.

Alleviation (d682057ecb0e254069773d64f32c068cedb71e2a):

The correct storage slot has been specified as advised.