Omniscia Nexera Audit
FundingErc20PacketsFacetStorage Code Style Findings
FundingErc20PacketsFacetStorage Code Style Findings
FEF-01C: Inexistent Documentation of Storage Slot
| Type | Severity | Location |
|---|---|---|
| Code Style |  | FundingErc20PacketsFacetStorage.sol:L50-L52 |
Description:
The referenced STORAGE_SLOT does not have its actual result specified in its in-line documentation in contrast to other segments of the codebase.
Example:
packages/contracts/contracts/genericFacets/fundingPacketFacet/fundingErc20Packets/FundingErc20PacketsFacetStorage.sol
49/// @dev Unique identifier for the storage slot where the Layout struct is stored. Derived from the ERC7201 formula.50bytes32 internal constant STORAGE_SLOT =51 keccak256(abi.encode(uint256(keccak256("evergonlabs.Tmi-Tokenizer.storage.FundingErc20PacketsFacetStorage")) - 1)) &52 ~bytes32(uint256(0xff));Recommendation:
We advise the 0xc5a0dab71c8dd0292bf4ca27f424f292b7208ec27008f40e0214b12a05ec8b00 storage slot to be properly specified in its comments, aiding in debugging of the contract's structure.
Alleviation (d682057ecb0e254069773d64f32c068cedb71e2a):
The correct storage slot has been specified as advised.