Omniscia Nexera Audit

StablePriceFacetStorage Code Style Findings

StablePriceFacetStorage Code Style Findings

SPS-01C: Inexistent Documentation of Storage Slot

Description:

The referenced STORAGE_SLOT does not have its actual result specified in its in-line documentation as it remains a TO_DO.

Example:

packages/contracts/contracts/genericFacets/priceFacets/stablePriceFacet/StablePriceFacetStorage.sol
27/**
28 * @dev Unique identifier for the storage slot where the Layout struct is stored. Derived from the ERC7201 formula.
29 * STORAGE_SLOT: TO_DO
30 */
31bytes32 internal constant STORAGE_SLOT =
32    keccak256(abi.encode(uint256(keccak256("Evergonlabs.Tmi-Tokenizer.storage.StablePriceFacetStorage")) - 1)) &
33        ~bytes32(uint256(0xff));

Recommendation:

We advise the 0x1eb8b0ca754a390bbee8369eefbfddffa946690ef5f1cf9d902f35f1ed4c1300 storage slot to be properly specified in its comments, aiding in debugging of the contract's structure.

Alleviation (d682057ecb0e254069773d64f32c068cedb71e2a):

The correct storage slot has been specified as advised.

Prev

StablePriceFacet.sol (SPF-C)

Next

WrapAssetsFacetStorage.sol (WAS-C)

On this page