Omniscia Nexera Audit

Erc1155NonGenesisFractionFacetStorage Code Style Findings

Erc1155NonGenesisFractionFacetStorage Code Style Findings

ENG-01C: Inexistent Documentation of Storage Slot

Description:

The referenced STORAGE_SLOT does not have its actual result specified in its in-line documentation as it remains a TO-DO.

Example:

packages/contracts/contracts/internalFacets/createFractionsPhaseFacets/fractionFacets/erc1155/nonGenesisIds/Erc1155NonGenesisFractionFacetStorage.sol
28/** ================================================== STORAGE =================================================
29 * @dev Unique identifier for the storage slot where the Layout struct is stored. Derived from the ERC7201 formula.
30 * STORAGE_SLOT: TO-DO
31 */
32bytes32 internal constant STORAGE_SLOT =
33 keccak256(abi.encode(uint256(keccak256("Evergonlabs.Tmi-Tokenizer.storage.Erc1155NonGenesisFractionFacetStorage")) - 1)) &
34 ~bytes32(uint256(0xff));

Recommendation:

We advise the 0xfa7da8d29ad36c71628947642fec94f33a7f49f511e62bde4d21475fbdd6a500 storage slot to be properly specified in its comments, aiding in debugging of the contract's structure.

Alleviation (d682057ecb0e254069773d64f32c068cedb71e2a):

The correct storage slot has been specified as advised.