Omniscia Olympus DAO Audit
BondTeller Code Style Findings
BondTeller Code Style Findings
BTR-01C: Inexistent Variable Visibility Specifiers
Type | Severity | Location |
---|---|---|
Code Style | Informational | BondTeller.sol:L44-L49 |
Description:
The linked variables have no visibility specifier explicitly set.
Example:
contracts/BondTeller.sol
44address depository; // contract where users deposit bonds45IStaking immutable staking; // contract to stake payout46ITreasury immutable treasury;47IERC20 immutable OHM;48IERC20 immutable sOHM; // payment token49IgOHM immutable gOHM;
Recommendation:
We advise one to be set so to avoid potential compilation discrepancies in the future as the current compiler behaviour is to assign a specifier automatically.
Alleviation:
All variables were set to internal
thereby alleviating this exhibit.