Omniscia BlazeSwap Audit
Babylonian Code Style Findings
Babylonian Code Style Findings
BAB-01C: Incorrect Line Reference
Type | Severity | Location |
---|---|---|
Code Style | Babylonian.sol:L8 |
Description:
The linked line reference contains a link pointing to the master
branch which is expected to change and is currently incorrect.
Example:
contracts/shared/libraries/Babylonian.sol
7// credit for this implementation goes to8// https://github.com/abdk-consulting/abdk-libraries-solidity/blob/master/ABDKMath64x64.sol#L6879function sqrt(uint256 x) internal pure returns (uint256) {
Recommendation:
We advise the commit hash to be pinned and the correct line to be specified ensuring that the code can be properly correlated to the original ABDK math implementation.
Alleviation:
The BlazeSwap team considered this exhibit but opted not to apply a remediation for it as they have stated they will not remediate any issues of minor severity and below.