BlazeSwapFAssetRewardPlugin Manual Review Findings

BFA-01M: Incomplete Implementation

Type	Severity	Location
Code Style		BlazeSwapFAssetRewardPlugin.sol:L7-L17

Description:

As per the documentation of the BlazeSwap repository, F-Assets and associated rewards are not meant to be supported by the BlazeSwap DEX yet as they have not been finalized specification-wise by the Flare network.

Example:

Copy
7contract BlazeSwapFAssetRewardPlugin is IBlazeSwapFAssetRewardPlugin {
8    address public implementation = address(new BlazeSwapFAssetReward());
9
10    uint256 public immutable testValue1;
11    string public testValue2;
12
13    constructor(uint256 _testValue1, string memory _testValue2) {
14        testValue1 = _testValue1;
15        testValue2 = _testValue2;
16    }
17}

Recommendation:

We advise the code to be explicitly marked as test code to avoid potential ambiguities when the actual implementation is introduced to the codebase.

Alleviation:

The BlazeSwap team stated that this contract is a stub and thus should not have been in scope of the audit. As a result, we consider this exhibit nullified.