Omniscia BlazeSwap Audit
BlazeSwapDelegationPlugin Static Analysis Findings
BlazeSwapDelegationPlugin Static Analysis Findings
BDP-01S: Inexistent Sanitization of Input Address
Type | Severity | Location |
---|---|---|
Input Sanitization | BlazeSwapDelegationPlugin.sol:L13-L15 |
Description:
The linked function accepts an address
argument yet does not properly sanitize it.
Impact:
The presence of zero-value addresses, especially in constructor
implementations, can cause the contract to be permanently inoperable. These checks are advised as zero-value inputs are a common side-effect of off-chain software related bugs.
Example:
contracts/core/BlazeSwapDelegationPlugin.sol
13constructor(address _configurable) {14 initCentrallyConfigurable(_configurable);15}
Recommendation:
We advise some basic sanitization to be put in place by ensuring that the address
specified is non-zero.
Alleviation:
The initCentrallyConfigurable
function of the CentrallyConfigurable
contract was updated to perform the input sanitization check instead thereby alleviating this exhibit indirectly.