Omniscia BlazeSwap Audit
Configurable Static Analysis Findings
Configurable Static Analysis Findings
COF-01S: Inexistent Sanitization of Input Address
Type | Severity | Location |
---|---|---|
Input Sanitization | Configurable.sol:L35-L37 |
Description:
The linked function accepts an address
argument yet does not properly sanitize it.
Impact:
The presence of zero-value addresses, especially in constructor
implementations, can cause the contract to be permanently inoperable. These checks are advised as zero-value inputs are a common side-effect of off-chain software related bugs.
Example:
contracts/shared/Configurable.sol
35function setConfigSetter(address _configSetter) external onlyConfigSetter {36 ConfigurableStorage.layout().configSetter = _configSetter;37}
Recommendation:
We advise some basic sanitization to be put in place by ensuring that the address
specified is non-zero.
Alleviation:
The BlazeSwap team stated that the check is intentionally not present here to allow renunciation of configuration adjustments in the contract's lifetime. As a result, we consider this exhibit nullified.