Omniscia Moby Audit
BasePositionManager Code Style Findings
BasePositionManager Code Style Findings
BPM-01C: Deprecated Revert Pattern
| Type | Severity | Location |
|---|---|---|
| Standard Conformity |  | BasePositionManager.sol:L72 |
Description:
The referenced revert statement will yield a textual description of the error which is an abandoned practice.
Example:
contracts/BasePositionManager.sol
72revert("invalid _path.length");Recommendation:
We advise a custom error declaration to be introduced to the BasePositionManager and consequently utilized in place of the referenced message, optimizing the code's gas cost as well as legibility.
Alleviation (b02fae335f62cc1f5f4236fb4d982ad16a32bd26):
A require check is imposed instead which is considered a better approach to a text-based revert statement rendering this exhibit addressed.