Omniscia Moby Audit
PositionManager Static Analysis Findings
PositionManager Static Analysis Findings
PMR-01S: Suboptimal Event Declarations
Type | Severity | Location |
---|---|---|
Gas Optimization | PositionManager.sol:L158, L159 |
Description:
The referenced event
declarations do not have any indexed
argument or have less than three indexed
arguments that are a primitive type.
Example:
contracts/PositionManager.sol
158event SetExecutionFee(uint256 executionFee);
Recommendation:
Apart from aiding off-chain integrators in consuming and filtering such events, primitive types that are set as indexed
will result in a gas optimization due to reduced memory costs. As such, we advise the indexed
keyword to be introduced to up to three different primitive types in total optimizing the referenced event
declarations.
Alleviation (b02fae335f62cc1f5f4236fb4d982ad16a32bd26):
The Moby team evaluated this exhibit but opted to acknowledge it in the current iteration of the codebase