Omniscia Moby Audit
Context Code Style Findings
Context Code Style Findings
CTX-01C: Potentially Redundant Contract Implementation
Type | Severity | Location |
---|---|---|
Gas Optimization | Context.sol:L14-L22 |
Description:
The Context
implementation is meant to be utilized if the system is expected to comply with EIP-2771 and should be avoided otherwise as it incurs extraneous gas.
Example:
contracts/libraries/Context.sol
14abstract contract Context {15 function _msgSender() internal view virtual returns (address) {16 return msg.sender;17 }18
19 function _msgData() internal view virtual returns (bytes calldata) {20 return msg.data;21 }22}
Recommendation:
We advise the Moby team to evaluate whether they wish to integrate EIP-2771, and omit the Context
implementation if they do not wish so.
Alleviation (b02fae335f62cc1f5f4236fb4d982ad16a32bd26):
The Moby team evaluated this exhibit but opted to acknowledge it in the current iteration of the codebase