Omniscia Moby Audit
FastPriceFeed Static Analysis Findings
FastPriceFeed Static Analysis Findings
FPF-01S: Inexistent Event Emissions
| Type | Severity | Location |
|---|---|---|
| Language Specific |  | FastPriceFeed.sol:L49-L51, L53-L55, L57-L60, L62-L64, L67-L69 |
Description:
The linked functions adjust sensitive contract variables yet do not emit an event for it.
Example:
contracts/oracles/FastPriceFeed.sol
49function setFastPriceEvents(address _fastPriceEvents) external onlyAdmin {50 fastPriceEvents = _fastPriceEvents;51}Recommendation:
We advise an event to be declared and correspondingly emitted for each function to ensure off-chain processes can properly react to this system adjustment.
Alleviation (a8720219a6a97e10b8d9c6a70c6345747f0fdcb3):
The SetFastPriceEvents, SetMaxTimeDeviation, SetUpdateDuration, and SetLastUpdatedAt events were introduced to the codebase and are correspondingly emitted in the FastPriceFeed::setFastPriceEvents, FastPriceFeed::setMaxTimeDeviation, FastPriceFeed::setUpdateDuration, and FastPriceFeed::setLastUpdatedAt functions respectively, addressing this exhibit in full.