Omniscia Moby Audit

ERC1155BaseStorage Manual Review Findings

ERC1155BaseStorage Manual Review Findings

ERG-01M: Non-Standard Storage Slot Offset

Description:

The referenced storage slot offset does not comply with EIP-1967 or EIP-7201.

Example:

contracts/tokens/erc1155/ERC1155BaseStorage.sol
11bytes32 internal constant STORAGE_SLOT =
12 keccak256('solidstate.contracts.storage.ERC1155Base');

Recommendation:

We advise the storage slot offset as well as accompanying Layout structure to be made compliant with either of the aforementioned standards, ensuring that the code complies with the latest Solidity development guidelines in relation to upgradeable contracts.

Alleviation (b02fae335f62cc1f5f4236fb4d982ad16a32bd26):

The Moby team evaluated this exhibit and clarified that the contract is already commercialized and utilized, meaning that they do not wish to adjust the storage offsets as a result.