Omniscia Moby Audit
MintableBaseToken Static Analysis Findings
MintableBaseToken Static Analysis Findings
MBT-01S: Inexistent Event Emission
| Type | Severity | Location |
|---|---|---|
| Language Specific |  | MintableBaseToken.sol:L24-L26 |
Description:
The linked function adjusts a sensitive contract variable yet does not emit an event for it.
Example:
contracts/tokens/MintableBaseToken.sol
24function setMinter(address _minter, bool _isActive) external override onlyAdmin {25 isMinter[_minter] = _isActive;26}Recommendation:
We advise an event to be declared and correspondingly emitted to ensure off-chain processes can properly react to this system adjustment.
Alleviation (b02fae335f62cc1f5f4236fb4d982ad16a32bd26):
The _minter event was introduced to the codebase and is correspondingly emitted in the MintableBaseToken::setMinter function, addressing this exhibit in full.