ERC20 Manual Review Findings

ERC-01M: Improper Mock Adjustments

Type	Severity	Location
Logical Fault		ERC20.sol:L40, L61, L222-L226

Description:

The referenced segments represent mock adjustments that should be removed from production code.

In this particular instance, the variable introduced (owner) also introduces variable shadowing issues with several functions of the ERC20 token.

Impact:

All TODO related adjustments will be marked as informational given that they present "known-issues".

Example:

Copy
222// for mock
223function mint(address account, uint256 amount) external {
224  require(msg.sender == owner);
225  _mint(account, amount);
226}

Recommendation:

We advise them to be omitted, preventing mock implementations from seeping into production deployments.

Alleviation (b02fae335f62cc1f5f4236fb4d982ad16a32bd26):

The mock adjustments have all been removed from the contract, alleviating this exhibit in full.