Omniscia Xcaliswap Audit
Bribe Code Style Findings
Bribe Code Style Findings
BEB-01C: Generic Typographic Mistakes
| Type | Severity | Location |
|---|---|---|
| Code Style |  | Bribe.sol:L9, L246 |
Description:
The referenced lines contain typographical mistakes or generic documentational errors (i.e. copy-paste) that should be corrected.
Example:
contracts/periphery/Bribe.sol
9// Bribes pay out rewards for a given pool based on the votes that were received from the user (goes hand in hand with BaseV1Gauges.vote())Recommendation:
We advise them to be corrected enhancing the legibility of the codebase.
Alleviation:
The Xcaliswap team has corrected the typographic mistakes.
BEB-02C: Inexistent Error Message
| Type | Severity | Location |
|---|---|---|
| Code Style | | Bribe.sol:L78 |
Description:
The linked require check has no error message explicitly defined.
Example:
contracts/periphery/Bribe.sol
78require(_unlocked == 1);Recommendation:
We advise one to be set so to increase the legibility of the codebase and aid in validating the require check's condition.
Alleviation:
The Xcaliswap team evaluated this exhibit but opted not to apply any changes for it in the current iteration of the protocol.