Omniscia Xcaliswap Audit

RouterUtil Static Analysis Findings

RouterUtil Static Analysis Findings

RUL-01S: Inexistent Sanitization of Input Address

TypeSeverityLocation
Input SanitizationRouterUtil.sol:L16-L18

Description:

The linked function accepts an address argument yet does not properly sanitize it.

Impact:

The presence of zero-value addresses, especially in constructor implementations, can cause the contract to be permanently inoperable. These checks are advised as zero-value inputs are a common side-effect of off-chain software related bugs.

Example:

contracts/periphery/RouterUtil.sol
16constructor(address _router) {
17 router = IRouter(_router);
18}

Recommendation:

We advise some basic sanitization to be put in place by ensuring that the address specified is non-zero.

Alleviation:

The contract is no longer present in the codebase thus nullifying this exhibit.