Token Static Analysis Findings

TNE-01S: Inexistent Sanitization of Input Address

Type	Severity	Location
Input Sanitization		Token.sol:L25-L28

Description:

The linked function accepts an address argument yet does not properly sanitize it.

Impact:

The presence of zero-value addresses, especially in constructor implementations, can cause the contract to be permanently inoperable. These checks are advised as zero-value inputs are a common side-effect of off-chain software related bugs.

Example:

Copy
25function setMinter(address _minter) external {
26    require(msg.sender == minter);
27    minter = _minter;
28}

Recommendation:

We advise some basic sanitization to be put in place by ensuring that the address specified is non-zero.

Alleviation:

The Xcaliswap team has introduced a require check ensuring that the address specified is non-zero.