Omniscia Xcaliswap Audit
Voter Code Style Findings
Voter Code Style Findings
VRE-01C: Generic Typographic Mistakes
Type | Severity | Location |
---|---|---|
Code Style | ![]() | Voter.sol:L29, L32, L33, L34 |
Description:
The referenced lines contain typographical mistakes or generic documentational errors (i.e. copy-paste) that should be corrected.
Example:
contracts/periphery/Voter.sol
29mapping(address => address) public gauges; // pair => maturity => gauge
Recommendation:
We advise them to be corrected enhancing the legibility of the codebase.
Alleviation:
The Xcaliswap team evaluated this exhibit but opted not to apply any changes for it in the current iteration of the protocol.
VRE-02C: Inexistent Error Messages
Type | Severity | Location |
---|---|---|
Code Style | ![]() | Voter.sol:L67, L77, L93, L155-L156, L182-L183, L193-L194, L203, L229, L235, L240, L246, L317, L328, L389, L392 |
Description:
The linked require
checks have no error messages explicitly defined.
Example:
contracts/periphery/Voter.sol
67require(_unlocked == 1);
Recommendation:
We advise each to be set so to increase the legibility of the codebase and aid in validating the require
checks' conditions.
Alleviation:
The Xcaliswap team evaluated this exhibit but opted not to apply any changes for it in the current iteration of the protocol.