Omniscia Xcaliswap Audit
Router Code Style Findings
Router Code Style Findings
RRE-01C: Generic Typographic Mistakes
| Type | Severity | Location |
|---|---|---|
| Code Style |  | Router.sol:L26, L41, L43, L59, L60, L88, L178, L183, L250-L251, L342, L357, L370, L372, L383, L385 |
Description:
The referenced lines contain typographical mistakes or generic documentational errors (i.e. copy-paste) that should be corrected.
Example:
contracts/periphery/Router.sol
26require(deadline >= block.timestamp, 'BaseV1Router: EXPIRED');Recommendation:
We advise them to be corrected enhancing the legibility of the codebase.
Alleviation:
The Xcaliswap team evaluated this exhibit but opted not to apply any changes for it in the current iteration of the protocol.
RRE-02C: Inexistent Error Messages
| Type | Severity | Location |
|---|---|---|
| Code Style | | Router.sol:L165, L166, L246, L411, L414, L418, L421 |
Description:
The linked require checks have no error messages explicitly defined.
Example:
contracts/periphery/Router.sol
165require(amountADesired >= amountAMin);Recommendation:
We advise each to be set so to increase the legibility of the codebase and aid in validating the require checks' conditions.
Alleviation:
The Xcaliswap team evaluated this exhibit but opted not to apply any changes for it in the current iteration of the protocol.