Omniscia Xcaliswap Audit

RouterUtil Code Style Findings

RouterUtil Code Style Findings

RUL-01C: Multiple Top-Level Declarations

TypeSeverityLocation
Code StyleRouterUtil.sol:L5, L9, L13

Description:

The linked declarations all represent top-level instances in a single file.

Example:

contracts/periphery/RouterUtil.sol
5interface ISwapPair {
6 function metadata() external view returns (uint dec0, uint dec1, uint r0, uint r1, bool st, address t0, address t1);
7}
8
9interface IRouter {
10 function pairFor(address tokenA, address tokenB, bool stable) external view returns (address pair);
11}
12
13contract RouterUtil {

Recommendation:

We advise each to be split to its dedicated file optimizing the legibility of the codebase.

Alleviation:

The contract is no longer present in the codebase thus nullifying this exhibit.