Omniscia Evergon Labs Audit
Code Style
Code Style
During the manual portion of the audit, we identified 83 optimizations that can be applied to the codebase that will decrease the operational cost associated with the execution of a particular function and generally ensure that the project complies with the latest best practices and standards in Solidity.
Additionally, this section of the audit contains any opinionated adjustments we believe the code should make to make it more legible as well as truer to its purpose.
These optimizations are enumerated below:
| ID | Severity | Addressed | Title |
|---|---|---|---|
| ACS-01C |  |  | Improper Role Definitions |
| ACS-02C | | | Inefficient mapping Lookups |
| ACS-03C | | | Non-Standard Storage Slot Definition |
| ACS-04C | | | Redundant Logical Structures |
| AUS-01C | |  | Inefficient mapping Lookups |
| AUS-02C | | | Non-Standard Storage Slot Definition |
| BAR-01C | | | Generic Typographic Mistake |
| BAR-02C | | | Redundant Named Function Argument |
| BFF-01C | | | Generic Typographic Mistake |
| BFD-01C | | | Non-Standard Storage Slot Definition |
| BFD-02C | | | Repetitive Value Literal |
| BSE-01C | | | Non-Standard Storage Slot Definition |
| CAT-01C | | | Non-Standard Storage Slot Definition |
| CFM-01C | | | Inefficient Code Structure |
| CFM-02C | | | Non-Standard Storage Slot Definition |
| CFG-01C | | | Ineffectual Usage of Safe Arithmetics |
| CFG-02C | | | Non-Standard Storage Slot Definition |
| CFS-01C | | | Inefficient mapping Lookups |
| CFN-01C | | | Inefficient mapping Lookups |
| COB-01C | | | Redundant Named Function Argument |
| COM-01C | | | Redundant Named Function Argument |
| DBF-01C | | | Non-Standard Storage Slot Definition |
| ERR-01C | | | Non-Standard Storage Slot Definition |
| EFS-01C | | | Inconsistent State Definitions |
| EFS-02C | | | Non-Standard Storage Slot Definition |
| FBF-01C | | | Non-Standard Storage Slot Definition |
| FDM-01C | | | Misleading Function Names |
| FDC-01C | | | Non-Standard Storage Slot Definition |
| FDC-02C | | | Redundant Conditional Structure |
| FIA-01C | | | Inefficient Data Management |
| FIA-02C | | | Misleading Function Name |
| FIA-03C | | | Non-Standard Storage Slot Definition |
| FIA-04C | | | Redundant Yielding of Buyback Amount |
| FIA-05C | | | Repetitive Value Literal |
| FAF-01C | | | Non-Standard Storage Slot Definition |
| FRF-01C | | | Inefficient Logic Structures |
| FRF-02C | | | Non-Standard Storage Slot Definition |
| FAS-01C | | | Non-Standard Storage Slot Definition |
| GSE-01C | | | Non-Standard Storage Slot Definition |
| LOS-01C | | | Combination of Logical Clauses |
| LOS-02C | | | Ineffectual Usage of Safe Arithmetics |
| LOS-03C | | | Misleading Codebase Notions |
| LOS-04C | | | Non-Standard Storage Slot Definition |
| LOS-05C | | | Repetitive Value Literal |
| LRF-01C | | | Non-Standard Storage Slot Definition |
| MFF-01C | | | Non-Standard Storage Slot Definition |
| MFF-02C | | | Repetitive Value Literal |
| MSF-01C | | | Non-Standard Storage Slot Definition |
| NFP-01C | | | Non-Standard Storage Slot Definition |
| NFP-02C | | | Unused Library Implementation |
| OBF-01C | | | Non-Standard Storage Slot Definition |
| PPF-01C | | | Inefficient mapping Lookups |
| PPF-02C | | | Non-Standard Storage Slot Definition |
| PDM-01C | | | Generic Typographic Mistake |
| PDS-01C | | | Non-Standard Storage Slot Definition |
| PRF-01C | | | Non-Standard Storage Slot Definition |
| PTA-01C | | | Non-Standard Storage Slot Definition |
| RAE-01C | | | Non-Standard Storage Slot Definition |
| RAF-01C | | | Non-Standard Storage Slot Definition |
| RAG-01C | | | Redundant Named Function Argument |
| RBF-01C | | | Redundant Named Function Argument |
| SFF-01C | | | Non-Standard Storage Slot Definition |
| SFF-02C | | | Repetitive Value Literal |
| SSF-01C | | | Non-Standard Storage Slot Definition |
| SSA-01C | | | Non-Standard Storage Slot Definition |
| SSC-01C | | | Non-Standard Storage Slot Definition |
| SSG-01C | | | Non-Standard Storage Slot Definition |
| SSE-01C | | | Non-Standard Storage Slot Definition |
| SSO-01C | | | Non-Standard Storage Slot Definition |
| SSS-01C | | | Non-Standard Storage Slot Definition |
| SFS-01C | | | Non-Standard Storage Slot Definition |
| TFA-01C | | | Redundant Named Function Arguments |
| TFO-01C | | | Redundant Named Function Arguments |
| TBT-01C | | | Redundant Initialization Mechanism |
| TBF-01C | | | Non-Standard Storage Slot Definition |
| TCA-01C | | | Inefficient mapping Lookups |
| TCA-02C | | | Non-Standard Storage Slot Definition |
| TCA-03C | | | Redundant Conditional Structure |
| UPV-01C | | | Redundant Named Function Argument |
| UPF-01C | | | Non-Standard Storage Slot Definition |
| WCS-01C | | | Inefficient Code Structure |
| WCS-02C | | | Non-Standard Storage Slot Definition |
| WAS-01C | | | Non-Standard Storage Slot Definition |