Omniscia Evergon Labs Audit
SingleStateNonFundedFacetStorage Code Style Findings
SingleStateNonFundedFacetStorage Code Style Findings
SSG-01C: Non-Standard Storage Slot Definition
| Type | Severity | Location |
|---|---|---|
| Standard Conformity |  | SingleStateNonFundedFacetStorage.sol:L23 |
Description:
The referenced declaration will define a storage slot for use by a facet of the system's main EIP-2535 Diamond, however, the way it is declared does not adhere to the latest standards.
Example:
packages/contracts/contracts/subInternalFacets/nonFundedPhaseFacets/nonFundedStateFacets/SingleStateNonFundedFacetStorage.sol
23bytes32 internal constant STORAGE_SLOT = keccak256("Evergonlabs.Tmi-Tokenizer.storage.SingleStateNonFundedFacetStorage");Recommendation:
We advise the EIP-7201 name-spaced layout approach to be adhered to similarly to OpenZeppelin and other relevant standard libraries, ensuring consistency among the ecosystem's widely utilized libraries and conforming to the latest standards.
Alleviation (71cda4ccfdcfa25fb96a4565f1f8143b350dd246):
The referenced slot definition has been updated to its standardized EIP-7201 representation, addressing this exhibit.