MultipleFundingCurrenciesFacetStorage Code Style Findings

MFF-01C: Non-Standard Storage Slot Definition

Type	Severity	Location
Standard Conformity		MultipleFundingCurrenciesFacetStorage.sol:L33

Description:

The referenced declaration will define a storage slot for use by a facet of the system's main EIP-2535 Diamond, however, the way it is declared does not adhere to the latest standards.

Example:

Copy
33bytes32 internal constant STORAGE_SLOT = keccak256("Evergonlabs.Tmi-Tokenizer.storage.MultipleFundingCurrenciesFacetStorage");

Recommendation:

We advise the EIP-7201 name-spaced layout approach to be adhered to similarly to OpenZeppelin and other relevant standard libraries, ensuring consistency among the ecosystem's widely utilized libraries and conforming to the latest standards.

Alleviation (71cda4ccfdcfa25fb96a4565f1f8143b350dd246):

The referenced slot definition has been updated to its standardized EIP-7201 representation, addressing this exhibit.

MFF-02C: Repetitive Value Literal

Type	Severity	Location
Code Style		MultipleFundingCurrenciesFacetStorage.sol:L34

Description:

The linked value literal is repeated across the codebase multiple times.

Example:

Copy
34uint256 internal constant BASE_100_PERCENT = 10 ** 6;

Recommendation:

We advise it to be set to a constant variable instead, optimizing the legibility of the codebase.

In case the constant has already been declared, we advise it to be properly re-used across the code.

Alleviation (71cda4ccfdcfa25fb96a4565f1f8143b350dd246):

The referenced value literal is no longer required by the contract, rendering this exhibit inapplicable.