Omniscia Evergon Labs Audit
TransferFundsOnBuybackFacet Code Style Findings
TransferFundsOnBuybackFacet Code Style Findings
TFO-01C: Redundant Named Function Arguments
| Type | Severity | Location |
|---|---|---|
| Gas Optimization |  | TransferFundsOnBuybackFacet.sol: • I-1: L19 • I-2: L21 |
Description:
The TransferFundsOnBuybackFacet::initDoBuybackFacet and TransferFundsOnBuybackFacet::setAndCheckDoBuyback functions will redundantly use an explicit name for their input argument even though it remains unused.
Example:
packages/contracts/contracts/internalFacets/buybackPhaseFacets/doBuybackFacets/transferFundsOnBuyback/TransferFundsOnBuybackFacet.sol
19function initDoBuybackFacet(bytes calldata initDoBuybackData) external onlyExternalDelegateCall {}Recommendation:
We advise the explicit name to be removed on each instance, ensuring the function still adheres to the desired function selector yet does not waste extraneous gas.
Alleviation (71cda4ccfdcfa25fb96a4565f1f8143b350dd246):
An initialization process has been introduced for the facet rendering the input argument necessary and this exhibit to be inapplicable.