Omniscia Evergon Labs Audit

CreatorOnlyMarginCallEligibilityFacet Code Style Findings

CreatorOnlyMarginCallEligibilityFacet Code Style Findings

COM-01C: Redundant Named Function Argument

Description:

The CreatorOnlyMarginCallEligibilityFacet::initMarginCallHedgerEligibilityFacet function will redundantly use an explicit name for its input argument even though it remains unused.

Example:

packages/contracts/contracts/subInternalFacets/marginCallPhaseFacets/marginCallEligibilityFacets/creatorOnlyEligibility/CreatorOnlyMarginCallEligibilityFacet.sol
17function initMarginCallHedgerEligibilityFacet(
18 bytes calldata initMarginCallHedgerEligibilityData
19) external onlyExternalDelegateCall {}

Recommendation:

We advise the explicit name to be removed, ensuring the function still adheres to the desired function selector yet does not waste extraneous gas.

Alleviation (71cda4ccfdcfa25fb96a4565f1f8143b350dd246):

The redundantly named argument has been removed as advised, optimizing the code's syntax as well as gas cost.