Omniscia Evergon Labs Audit
UniformlyProvidedVestingFacet Code Style Findings
UniformlyProvidedVestingFacet Code Style Findings
UPV-01C: Redundant Named Function Argument
| Type | Severity | Location |
|---|---|---|
| Gas Optimization | ![]() | UniformlyProvidedVestingFacet.sol:L15 |
Description:
The UniformlyProvidedVestingFacet::initDoVestingActionsFacet function will redundantly use an explicit name for its input argument even though it remains unused.
Example:
packages/contracts/contracts/subInternalFacets/vestingPhaseFacets/doVestingActionFacets/uniformlyProvidedVesting/UniformlyProvidedVestingFacet.sol
15function initDoVestingActionsFacet(bytes calldata initDoVestingActionsData) external {}Recommendation:
We advise the explicit name to be removed, ensuring the function still adheres to the desired function selector yet does not waste extraneous gas.
Alleviation (71cda4ccfdcfa25fb96a4565f1f8143b350dd246):
The redundantly named argument has been removed as advised, optimizing the code's syntax as well as gas cost.
