Omniscia Evergon Labs Audit
ReceiveAllGatheredFundsFacet Code Style Findings
ReceiveAllGatheredFundsFacet Code Style Findings
RAG-01C: Redundant Named Function Argument
| Type | Severity | Location |
|---|---|---|
| Gas Optimization | ![]() | ReceiveAllGatheredFundsFacet.sol:L19 |
Description:
The ReceiveAllGatheredFundsFacet::initDoReceiveFacet function will redundantly use an explicit name for its input argument even though it remains unused.
Example:
packages/contracts/contracts/internalFacets/receivePhaseFacets/doReceiveFacets/receiveAllGatheredFunds/ReceiveAllGatheredFundsFacet.sol
19function initDoReceiveFacet(bytes calldata initDoReceiveData) external onlyExternalDelegateCall {}Recommendation:
We advise the explicit name to be removed, ensuring the function still adheres to the desired function selector yet does not waste extraneous gas.
Alleviation (71cda4ccfdcfa25fb96a4565f1f8143b350dd246):
An initialization process has been introduced for the facet rendering the input argument necessary and this exhibit to be inapplicable.
