Omniscia Evergon Labs Audit
CreatorOnlyBuybackEligibilityFacet Code Style Findings
CreatorOnlyBuybackEligibilityFacet Code Style Findings
COB-01C: Redundant Named Function Argument
| Type | Severity | Location |
|---|---|---|
| Gas Optimization | ![]() | CreatorOnlyBuybackEligibilityFacet.sol:L17 |
Description:
The CreatorOnlyBuybackEligibilityFacet::initBuybackEligibilityFacet function will redundantly use an explicit name for its input argument even though it remains unused.
Example:
packages/contracts/contracts/internalFacets/buybackPhaseFacets/buybackEligibilityFacets/creatorOnlyEligibility/CreatorOnlyBuybackEligibilityFacet.sol
17function initBuybackEligibilityFacet(bytes calldata initBuybackEligibilityData) external onlyExternalDelegateCall {}Recommendation:
We advise the explicit name to be removed, ensuring the function still adheres to the desired function selector yet does not waste extraneous gas.
Alleviation (71cda4ccfdcfa25fb96a4565f1f8143b350dd246):
The redundantly named argument has been removed as advised, optimizing the code's syntax as well as gas cost.
