Omniscia Evergon Labs Audit
BurnFungibleForDiscountFacetStorage Static Analysis Findings
BurnFungibleForDiscountFacetStorage Static Analysis Findings
BFD-01S: Illegible Numeric Value Representation
| Type | Severity | Location |
|---|---|---|
| Code Style |  | BurnFungibleForDiscountFacetStorage.sol:L30 |
Description:
The linked representation of a numeric literal is sub-optimally represented decreasing the legibility of the codebase.
Example:
30uint256 internal constant BASE_100_PERCENT = 10 ** 6;Recommendation:
To properly illustrate the value's purpose, we advise the following guidelines to be followed.
For values meant to depict fractions with a base of 1e18, we advise fractions to be utilized directly (i.e. 1e17 becomes 0.1e18) as they are supported.
For values meant to represent a percentage base, we advise each value to utilize the underscore (_) separator to discern the percentage decimal (i.e. 10000 becomes 100_00, 300 becomes 3_00 and so on).
Finally, for large numeric values we simply advise the underscore character to be utilized again to represent them (i.e. 1000000 becomes 1_000_000).
Alleviation (71cda4ccfdcfa25fb96a4565f1f8143b350dd246):
The referenced value literal has been updated in its representation to 100_0000 in accordance with the recommendation's underscore style, addressing this exhibit.